chore: add column selection in eval comparison page #2632

gtarpenning · 2024-10-08T18:27:44Z

Description

In this pr:

adds a button to configure the metrics on the eval comparison page.
configure popup should behave like the calls page column selector
selected metrics are included/excluded in all relevant sections of the page
configured metrics are added to the URL so you can share a page with specifics metrics configured

TODO:

~~should metric selection apply throughout the eval suite? Probably right... So this might need to be added to state so that the other components can figure out which columns are selected~~
~~add column selection state to URL encoding~~

This PR:

How was this PR tested?

circle-job-mirror · 2024-10-08T18:31:39Z

…-metrics

gtarpenning added 3 commits October 8, 2024 11:26

chore: add column selection in eval summary

b8d7417

undo state change

6db0cc6

comment

3f1bd8a

gtarpenning added 3 commits October 9, 2024 10:45

column selection affects the whole page, and is stored in url state

1fbaabc

cleanup

7d5d147

Merge remote-tracking branch 'origin/master' into griffin/eval-select…

e01a8ca

…-metrics

gtarpenning marked this pull request as ready for review October 9, 2024 19:31

gtarpenning requested review from a team as code owners October 9, 2024 19:31

Merge branch 'master' into griffin/eval-select-metrics

0c8ae0d

tssweeney approved these changes Oct 10, 2024

View reviewed changes

gtarpenning added 2 commits October 10, 2024 11:15

merge

5aa0d02

better handle initial state and derived metrics

9632778

gtarpenning changed the title ~~chore: add column selection in eval summary~~ chore: add column selection in eval comparison page Oct 10, 2024

gtarpenning merged commit 1e3f239 into master Oct 10, 2024
100 checks passed

gtarpenning deleted the griffin/eval-select-metrics branch October 10, 2024 21:32

github-actions bot locked and limited conversation to collaborators Oct 10, 2024